Gilad Chaplik has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 6: (3 comments) please verify. there are some comments that weren't addressed. http://gerrit.ovirt.org/#/c/26943/6/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4174: </xs:complexType> Line 4175: Line 4176: <xs:complexType name="VirtualNumaNode"> Line 4177: <xs:complexContent> Line 4178: <xs:extension base="BaseDevice"> should be base=NumaNode Line 4179: <xs:sequence> Line 4180: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4181: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4182: <xs:element name="numa_cpus" type="NumaCPUs" minOccurs="0" maxOccurs="1"/> Line 4187: </xs:complexType> Line 4188: Line 4189: <xs:complexType name="VirtualNumaNodes"> Line 4190: <xs:complexContent> Line 4191: <xs:extension base="BaseDevices"> should be base=NumaNodes Line 4192: <xs:sequence> Line 4193: <xs:element ref="vm_numa_node" minOccurs="0" maxOccurs="unbounded"> Line 4194: <xs:annotation> Line 4195: <xs:appinfo> Line 4206: Line 4207: <xs:element name="numa_node_pin" type="NumaNodePin"/> Line 4208: Line 4209: <xs:element name="numa_cpus" type="NumaCPUs"/> Line 4210: remove trailing white space.. Line 4211: <xs:element name="numa_cpu" type="NumaCPU"/> Line 4212: Line 4213: <xs:complexType name="NumaNodePins"> Line 4214: <xs:sequence> -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
