Gilad Chaplik has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26943/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4160: </xs:complexType> Line 4161: Line 4162: <xs:complexType name="VirtualNumaNode"> Line 4163: <xs:complexContent> Line 4164: <xs:extension base="BaseDevice"> > As Jason said, BaseResource and BaseDevice are the only base classes in res BaseResource is editable as well, I don't get your point. IMO BaseDevice isn't related to numa at all. Line 4165: <xs:sequence> Line 4166: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4167: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4168: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
