Gilad Chaplik has posted comments on this change.

Change subject: restapi: NUMA feature restful API support
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.ovirt.org/#/c/26943/8/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd:

Line 4205:         <xs:sequence>
Line 4206:           <xs:element ref="host" minOccurs="0" maxOccurs="1"/>
Line 4207:           <xs:element name="index" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Line 4208:           <xs:element name="memory" type="xs:long" minOccurs="0" 
maxOccurs="1"/>
Line 4209:           <xs:element name="numa_cpus" type="NumaCPUs" minOccurs="0" 
maxOccurs="1"/>
not sure we need a separate type for NumaCPUs
Line 4210:           <xs:element name="statistics" type="Statistics" 
minOccurs="0" maxOccurs="1"/>
Line 4211:           <xs:element name="node_distance" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 4212:         </xs:sequence>
Line 4213:       </xs:extension>


Line 4278:           <jaxb:property generateIsSetMethod="false"/>
Line 4279:         </xs:appinfo>
Line 4280:       </xs:annotation>
Line 4281:     </xs:attribute>
Line 4282:     <xs:attribute name="index" type="xs:int" use="required"/>
missing pNode ref.
Line 4283:   </xs:complexType>
Line 4284: 
Line 4285:   <xs:complexType name="NumaCPUs">
Line 4286:     <xs:sequence>


-- 
To view, visit http://gerrit.ovirt.org/26943
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jason Liao <chuan.l...@hp.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to