Jason Liao has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 4: (6 comments) http://gerrit.ovirt.org/#/c/26943/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4134: <xs:sequence> Line 4135: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4136: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4137: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4138: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> > because REST is backward compatible, we need to make sure we can later inte You are right, I will try to modify it to a object Line 4139: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4140: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4141: </xs:sequence> Line 4142: </xs:extension> Line 4135: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4136: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4137: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4138: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4139: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> > can't understand what's statistics here? should be NumaNodeStat... The restful API has the standard statistics data structure. The NUMA node statistics data transform standard data structure and show to User, Is that OK, @Juan Line 4140: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4141: </xs:sequence> Line 4142: </xs:extension> Line 4143: </xs:complexContent> Line 4160: </xs:complexType> Line 4161: Line 4162: <xs:complexType name="VirtualNumaNode"> Line 4163: <xs:complexContent> Line 4164: <xs:extension base="BaseDevice"> > sorry getting late, why extend base device? vNuma node should extend pNuma The two base data structure are BaseResource and BaseDevice. BaseResource is Readonly and BaseDevice have add, update, remove methods. I have two ways to fix this: 1. Let the pNUMA extend BaseDevice. and the vNUMA extend pNUMA. ( That will be confused user, because pNUMA will not add, update, remove from restful API ) 2. Do big change on vNUMA implementation, follow the BaseDevice, implement add, update, remove methods. What is your opinion? @Gilad, @Juan Line 4165: <xs:sequence> Line 4166: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4167: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4168: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4165: <xs:sequence> Line 4166: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4167: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4168: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4169: <xs:element name="pin_host_node_list" type="xs:string" minOccurs="0" maxOccurs="1"/> > All above should be removed. follow the prior question. Line 4170: </xs:sequence> Line 4171: </xs:extension> Line 4172: </xs:complexContent> Line 4173: </xs:complexType> Line 4185: </xs:element> Line 4186: </xs:sequence> Line 4187: </xs:extension> Line 4188: </xs:complexContent> Line 4189: </xs:complexType> > Am I wrong or we're missing Host cpu statistics? The host CPU statistics data will under the host section, will be in a separated patch. ( not include in this patch, this patch only have the NUMA nodes section information ), @Juan, do you think we could let the host CPU statistics data under the host section. I mean /hosts/{host:id}/cpustatistics Line 4185: </xs:element> Line 4186: </xs:sequence> Line 4187: </xs:extension> Line 4188: </xs:complexContent> Line 4189: </xs:complexType> > and also VM and VDS related numa fields. Accetped -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
