Gilad Chaplik has posted comments on this change.

Change subject: engine: NUMA feature actions and queries
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/26810/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java:

Line 88: 
Line 89:     // NUMA
Line 90:     GetVdsNumaNodeByVdsId(VdcQueryAuthType.User),
Line 91:     GetVmNumaNodeByVmId(VdcQueryAuthType.User),
Line 92:     GetVmNumaNodeByVdsNumaNodeId(VdcQueryAuthType.User),
> I will add type of GetVmsWithNumaByClusterId, is that OK?
yes, not sure we need GetVmNumaNodeByVdsNumaNodeId.
Line 93: 
Line 94:     // VdsGroups
Line 95:     GetVdsCertificateSubjectByVdsId(VdcQueryAuthType.User),
Line 96:     GetVdsCertificateSubjectByVmId(VdcQueryAuthType.User),


-- 
To view, visit http://gerrit.ovirt.org/26810
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f297311a49c051b7ae2daee540d96210bf1a66d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jason Liao <chuan.l...@hp.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to