Gilad Chaplik has posted comments on this change. Change subject: engine: NUMA feature actions and queries ......................................................................
Patch Set 4: Code-Review-1 (4 comments) the UI will require that this actions will be part of Add/Edit VM flow for logical transaction (add must have it, you first create the VM then set the nodes, that means that in rest here is suitable, create the VM then add vnodes. BUT** since the ui will move to work on REST, we will need this transaction also in rest.. but that will be handled by REST infra - no need to change REST, but ultimately the REST will use Add/edit VM, because the REST won't manage the logical transactions, it handles multiple requests (probably sth the UI will require from REST infra). http://gerrit.ovirt.org/#/c/26810/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 109: Line 110: // NUMA Line 111: AddVmNumaNode(170, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.NONE), Line 112: UpdateVmNumaNode(171, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.NONE), Line 113: RemoveVmNumaNode(172, ActionGroup.EDIT_VM_PROPERTIES, false, QuotaDependency.NONE), Instead of a single node, let's go for topology, IMHO will ease our work. in the UI for sure, and in this way update is remove and add. what do you say? and names here also should be plural. Line 114: Line 115: // VmTemplatesCommand Line 116: AddVmTemplate(201, ActionGroup.CREATE_TEMPLATE, QuotaDependency.BOTH), Line 117: UpdateVmTemplate(202, ActionGroup.EDIT_TEMPLATE_PROPERTIES, QuotaDependency.VDS_GROUP), http://gerrit.ovirt.org/#/c/26810/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 86: GetNetworkLabelsByDataCenterId, Line 87: GetNetworkLabelsByHostNicId, Line 88: Line 89: // NUMA Line 90: GetVdsNumaNodeByVdsId(VdcQueryAuthType.User), s/GetVdsNumaNodeByVdsId/GetVdsNumaNode(s/List)ByVdsId should be plural. Line 91: GetVmNumaNodeByVmId(VdcQueryAuthType.User), Line 92: GetVmNumaNodeByVdsNumaNodeId(VdcQueryAuthType.User), Line 93: Line 94: // VdsGroups Line 87: GetNetworkLabelsByHostNicId, Line 88: Line 89: // NUMA Line 90: GetVdsNumaNodeByVdsId(VdcQueryAuthType.User), Line 91: GetVmNumaNodeByVmId(VdcQueryAuthType.User), same^ Line 92: GetVmNumaNodeByVdsNumaNodeId(VdcQueryAuthType.User), Line 93: Line 94: // VdsGroups Line 95: GetVdsCertificateSubjectByVdsId(VdcQueryAuthType.User), Line 88: Line 89: // NUMA Line 90: GetVdsNumaNodeByVdsId(VdcQueryAuthType.User), Line 91: GetVmNumaNodeByVmId(VdcQueryAuthType.User), Line 92: GetVmNumaNodeByVdsNumaNodeId(VdcQueryAuthType.User), Thinking what is possible via the RESTful API and needed by the GUI: GetVmNumaNodeByVdsNumaNodeId using REST is very hard to implement so we will use the following one (so better to start now (also better for the GUI impl ease = win-win)): getAll_VmsIncludingNuma_InClusterByClusterId - VM including Numa, means VM BE will be filled with vnumalist Line 93: Line 94: // VdsGroups Line 95: GetVdsCertificateSubjectByVdsId(VdcQueryAuthType.User), Line 96: GetVdsCertificateSubjectByVmId(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/26810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f297311a49c051b7ae2daee540d96210bf1a66d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
