Gilad Chaplik has posted comments on this change.

Change subject: engine: NUMA feature actions and queries
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/26810/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java:

Line 47:     @Override
Line 48:     public AuditLogType getAuditLogTypeValue() {
Line 49:         return getSucceeded() ? 
AuditLogType.NUMA_ADD_VM_NUMA_NODE_SUCCESS
Line 50:                 : AuditLogType.NUMA_ADD_VM_NUMA_NODE_FAILED;
Line 51:     }
> missing cputune.
meant numatune_mode


http://gerrit.ovirt.org/#/c/26810/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommand.java:

Line 45:     @Override
Line 46:     public AuditLogType getAuditLogTypeValue() {
Line 47:         return getSucceeded() ? 
AuditLogType.NUMA_UPDATE_VM_NUMA_NODE_SUCCESS
Line 48:                 : AuditLogType.NUMA_UPDATE_VM_NUMA_NODE_FAILED;
Line 49:     }
> missing cputune.
meant numatune_mode


-- 
To view, visit http://gerrit.ovirt.org/26810
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f297311a49c051b7ae2daee540d96210bf1a66d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jason Liao <chuan.l...@hp.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to