Jason Liao has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 1: (5 comments) The unit test cases will publish in coming weeks http://gerrit.ovirt.org/#/c/26943/1/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4098: </xs:complexContent> Line 4099: </xs:complexType> Line 4100: Line 4101: <!-- NumaNodes --> Line 4102: > Make sure to remove trailing white space. Done Line 4103: <xs:element name="host_numanode" type="NumaNode"/> Line 4104: Line 4105: <xs:element name="host_numanodes" type="NumaNodes"/> Line 4106: Line 4114: <xs:sequence> Line 4115: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4116: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4117: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4118: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> > What will be the content of this string? CPU list inside NUMA node; String format: 0 1 2 3 4 5 6 7; I do not want a integer list, it is hard to read. Line 4119: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4120: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4121: </xs:sequence> Line 4122: </xs:extension> Line 4116: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4117: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4118: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4119: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4120: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> > What will be the content of this string? NUMA node distance information; String format: 10 16 20 16 10; Line 4121: </xs:sequence> Line 4122: </xs:extension> Line 4123: </xs:complexContent> Line 4124: </xs:complexType> Line 4145: <xs:sequence> Line 4146: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4147: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4148: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4149: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> > What will be the content of this string? The same as host NUMA node Line 4150: <xs:element name="pinhost_numanode_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4151: </xs:sequence> Line 4152: </xs:extension> Line 4153: </xs:complexContent> Line 4146: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4147: <xs:element name="index" type="xs:int" minOccurs="0"/> Line 4148: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4149: <xs:element name="cpu_list" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4150: <xs:element name="pinhost_numanode_list" type="xs:string" minOccurs="0" maxOccurs="1"/> > What will be the content of this string? Virtual NUMA node pin to host NUMA node information String format: "1 2"; or "1" Line 4151: </xs:sequence> Line 4152: </xs:extension> Line 4153: </xs:complexContent> Line 4154: </xs:complexType> -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
