anmolbabu has posted comments on this change. Change subject: engine : Refactored gluster volume profile query ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/27468/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java: Line 33: } Line 34: Line 35: protected GlusterVolumeProfileInfo setBrickNames(GlusterVolumeProfileInfo profileInfo) { Line 36: List<BrickProfileDetails> brickProfiles= profileInfo.getBrickProfileDetails(); Line 37: for(int i = 0; i < brickProfiles.size(); i++) { > for brickProfile in brickProfiles ?? did you mean for(BrickProfileDetails brickProfile : brickProfiles){ ...} Line 38: brickProfiles.get(i).setBrickName(DbFacade.getInstance().getGlusterBrickDao().getById(brickProfiles.get(i).getBrickId()).getQualifiedName()); Line 39: } Line 40: return profileInfo; Line 41: } http://gerrit.ovirt.org/#/c/27468/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java: Line 84: String convertedSize = ""; Line 85: while(size > 1024) { Line 86: Pair<SizeUnit, Double> result = SizeConverter.autoConvert(size, inUnit); Line 87: convertedSize = convertedSize.concat(result.getSecond().intValue() + " " + result.getFirst().toString() + " "); Line 88: long reminder = size - SizeConverter.convert(result.getSecond().longValue(), result.getFirst(), inUnit).longValue(); > %s/reminder/remainder/g Done Line 89: size = reminder; Line 90: } Line 91: convertedSize = convertedSize.concat((((convertedSize != "") && (size > 0)) || ((convertedSize == "") && (size == 0))) ? (size + " " + inUnit) : ""); Line 92: return convertedSize; -- To view, visit http://gerrit.ovirt.org/27468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
