anmolbabu has posted comments on this change. Change subject: engine : Refactored gluster volume profile query ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27468/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java: Line 31: Line 32: getQueryReturnValue().setReturnValue((((GlusterVolumeProfileParameters)getParameters()).isNfs()) ? (GlusterVolumeProfileInfo) returnValue.getReturnValue() : setBrickNames((GlusterVolumeProfileInfo) returnValue.getReturnValue())); Line 33: } Line 34: Line 35: protected GlusterVolumeProfileInfo setBrickNames(GlusterVolumeProfileInfo profileInfo) { > If this method sets some values and returns, better it could be renamed as Done Line 36: List<BrickProfileDetails> brickProfiles= profileInfo.getBrickProfileDetails(); Line 37: for(BrickProfileDetails brickProfileDetails : brickProfiles) { Line 38: brickProfileDetails.setBrickName(DbFacade.getInstance().getGlusterBrickDao().getById(brickProfileDetails.getBrickId()).getQualifiedName()); Line 39: } http://gerrit.ovirt.org/#/c/27468/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeProfileParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeProfileParameters.java: Line 6: public class GlusterVolumeProfileParameters extends GlusterVolumeQueriesParameters { Line 7: Line 8: /** Line 9: * Line 10: */ > Do we need above lines ?? No.I'll remove them in my next patch set Line 11: private static final long serialVersionUID = 1L; Line 12: Line 13: private boolean nfs; Line 14: -- To view, visit http://gerrit.ovirt.org/27468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
