Omer Frenkel has posted comments on this change.
Change subject: core: add memory balloon device support
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java
Line 111: public boolean isMemBalloonEnabled(Guid vmId) {
missing test for this method
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 579: addDevice(struct, vmDevice, null);
the above 4 lines repeated later, maybe extract to method
....................................................
Commit Message
Line 17: http://www.ovirt.org/wiki/Features/Design/memory-balloon
please update wiki with design changes that were made
--
To view, visit http://gerrit.ovirt.org/4993
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc2fed44feb3718b72f163755271ddc07b201265
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
