Yair Zaslavsky has posted comments on this change. Change subject: core: add memory balloon device support ......................................................................
Patch Set 4: (3 inline comments) Minor comments, Basically code-style and java-wise review. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java Line 33: private boolean isBalloonEnabled; ELi, convention is to name it as "ballonEnabled". This is a minor comment. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java Line 142: private boolean isBalloonEnabled = true; once again, consider renaming to balloonEnabled. .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java Line 222: // TODO Auto-generated method stub Can you please remove this //TODO and change to something else? -- To view, visit http://gerrit.ovirt.org/4993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2fed44feb3718b72f163755271ddc07b201265 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
