Michael Pasternak has posted comments on this change. Change subject: generator: Use Java to generate code ......................................................................
Patch Set 1: -Code-Review i understand this Juan and have no problem having single codegen for all clients (it's a right approach in my view as well - i mentioned that before), it just i don't want us drugging all the "crap" from old python-codegen to the new java-codegen (which is free of it) and you'll have no choice if you'll move current python-codegen to today's java-codegen cause you have to maintain old python-sdk interface, i know that you did huge work on this already, but i think that using python templates only with as-is java-codegen actually will be much easier at the end, it will create new python-sdk and you will only have to add two files params.py (that will point to all resource classes you've created) & brokers.py (that will point to all decorators to api resources/collections you've created) and that's it. since qa folks have extremely good coverage (which is used for api/sdk/cli testing and done via sdk itself), you can test for regressions very same day, and if coverage is not 100% you can use induction, cause if it works for collection X, it will work for collection Y and if it works for sub-collection X' it will work for sub-collection Y' (it's a same code after all) i know it sounds scary, and having 1:1 code with old sdk is safe cause you can compare, but it is not such a big deal when you'll earn clean code in python-sdk & won't drag forever legacy python-codegen code (in java form), if you want me i'll give you a list of old code i'd get rid of (which exist in python-sdk and does not exist in java-sdk -> cause lesson learned...) if i where you, i would doing it this way. -- To view, visit http://gerrit.ovirt.org/26977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia128d1b35d371f535b95407113902da7f2931d3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
