Juan Hernandez has posted comments on this change. Change subject: generator: Use Java to generate code ......................................................................
Patch Set 1: Yes, it is a literal translation of the current Python generator. In my opinion the first step should be to generate exactly the same code, as otherwise there is no way to verify that it isn't breaking things. The translation is done, and works fine, so I think is it at least as good as the Python generator, better in some areas, and ready to take its place. Once it is written in Java it becomes malleable, and easier to understand and to refactor. It isn't currently, at least not for me. It is not a matter of Python vs Java, I don't have anything against Python, just that all the people that I see as potential contributors (including myself) feel more confident with Java. With this refactoring capability it becomes possible to start moving code that is shared between both SDK generators to a common place. I expect to be able to use most of the Java SDK as-is, but I don't expect it to be trivial, thus I prefer to go step by step, having always working generated code. The other alternative looks to me too close to a big-bang. As I said, I don't see this as the end of the process, rather as the beginning. -- To view, visit http://gerrit.ovirt.org/26977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia128d1b35d371f535b95407113902da7f2931d3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
