Michael Pasternak has posted comments on this change. Change subject: generator: Use Java to generate code ......................................................................
Patch Set 1: Code-Review-1 Juan, you saying that it's translation of python-codegen to java? to generate same python-sdk code?!, java-codegen is a modular, ideally you should be adding python templates only to it and use new profile to trigger python code generation (i.e using python templates for codegen), forcing codegen-java to act as a codegen-python so it will produce same code as old python-sdk did (addressing languages conceptual differences, etc.), is using wrecking ball against codegen-java IMHO, if you remember i've mentioned that i did few mistakes in python-sdk (well it was first project of this kind and had own learning curve/constraints), which all i've addressed in the java-sdk later (including improved java-codegen), so now bringing all this noise to codegen-java just so it will produce same code as codegen-python do, is not such a good idea, - it will do more harm than good, having java generating python code (as a standalone project) means maintaining two codebases again, so it's not any different from the current situation, only produces extra noise. if you really want moving python-sdk code generation to codegen-java, you should: 1. add python templates to codegen-java (it will produce right python code) 2. add plugin to codegen-java creating proxy to new python-sdk (to remain old interface) 3. deprecate old python-sdk interface & get rid of it after three versions or so (optional). but if you asking me, its does not worth the effort, you not maintaining codegen-python that much, it was designed to not bother you after all. anyway if i can help in any way, don't hesitate contacting me. -- To view, visit http://gerrit.ovirt.org/26977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia128d1b35d371f535b95407113902da7f2931d3e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
