Vojtech Szocs has posted comments on this change. Change subject: ui-plugin : Trends Tab ......................................................................
Patch Set 31: (3 comments) http://gerrit.ovirt.org/#/c/25471/31//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-03-16 14:56:25 +0530 Line 4: Commit: Anmol Babu <anb...@redhat.com> Line 5: CommitDate: 2014-04-28 19:19:20 +0530 Line 6: Line 7: ui-plugin : Trends Tab Please indicate that this patch is for "gluster-nagios-dashboard" UI plugin, for example: gluster-nagios-dashboard: Add Trends tab Line 8: Line 9: Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 http://gerrit.ovirt.org/#/c/25471/31/gluster-nagios-dashboard/README File gluster-nagios-dashboard/README: Line 29: 1.To disable dashboard,Add Line 30: "showDashboard" : false Line 31: in config section of gluster-nagios-dashboard/gluster-nagios-dashboard.json Line 32: 2.To enable the tabs, messageOrigins field needs to be configured as, Line 33: "messageOrigins":["protocol://url:port"] protocol://engine-host:port Line 34: in config section of gluster-nagios-dashboard/gluster-nagios-dashboard.json Line 35: 3.If pnp4Nagios is configured on a server that is not engine server,add an entry as Line 36: "pnp4nagiosUrl" : "http://10.70.43.162"; Line 37: in config section of gluster-nagios-dashboard/gluster-nagios-dashboard.json http://gerrit.ovirt.org/#/c/25471/31/gluster-nagios-dashboard/src/js/dashboard-init.js File gluster-nagios-dashboard/src/js/dashboard-init.js: Line 8: Line 9: mod.factory('tabManager', ['pluginApi', '$window', 'urlUtil', function (pluginApi, $window, urlUtil) { Line 10: var tabWindow, selectedTreeItem; Line 11: return { Line 12: addTab: function () { Small thing, maybe this function should be named "addTabs" as it can add multiple tabs. Line 13: if(pluginApi.configObject().showDashboard) { Line 14: pluginApi.addMainTab('Dashboard', 'dashboard-tab', urlUtil.relativeUrl('dashboard.html')); Line 15: } Line 16: pluginApi.addMainTab('Trends', 'trends-tab', urlUtil.relativeUrl('trendsTab.html')); -- To view, visit http://gerrit.ovirt.org/25471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7c00636e380da154f7f457066fe89475d04c9b4 Gerrit-PatchSet: 31 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
