plysan has uploaded a new change for review. Change subject: engine: NPE in guide me dialog when exists pending approval host ......................................................................
engine: NPE in guide me dialog when exists pending approval host When updating guide me dialog's available option buttoms. Pending approval host's getSupportedClusterVersionsSet() returned null. The solution here is always provide a instance of HashSet when invoking parseSupportedVersions() Change-Id: I890738a6319dd721e518bb8c11bc4da6769a40ce Bug-Url: https://bugzilla.redhat.com/1091604 Signed-off-by: plysan <ply...@gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/27084/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java index fee2fb3..d95c709 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java @@ -468,14 +468,13 @@ * * @param supportedVersions * a string contains a concatenated list of supported versions - * @returns a set of the parsed versions, or null if {@code supportedVersions} provided empty. + * @returns a set of the parsed versions, or an empty set if {@code supportedVersions} provided empty. * @throws RuntimeException * thrown in case and parsing a version fails */ private HashSet<Version> parseSupportedVersions(String supportedVersions) { - HashSet<Version> parsedVersions = null; + HashSet<Version> parsedVersions = new HashSet<Version>(); if (!StringHelper.isNullOrEmpty(supportedVersions)) { - parsedVersions = new HashSet<Version>(); for (String ver : supportedVersions.split("[,]", -1)) { try { parsedVersions.add(new Version(ver)); -- To view, visit http://gerrit.ovirt.org/27084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I890738a6319dd721e518bb8c11bc4da6769a40ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: plysan <ply...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
