Sharad Mishra has posted comments on this change.

Change subject: core: Failed to create bond on 3.0 cluster (#827114)
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
Line 6: import org.ovirt.engine.core.common.businessentities.network;
Thats what I was thinking that it is an artifact of the conversion from C# to 
Java.

I will take a shot at refactoring this 'network' class.

I looked at redhat bugzilla for any open low hanging ovirt-engine/core/util 
bugs that need fixing. But couldn't find any. Is there a place where I can find 
them?

Line 51:         network network = getParameters().getNetwork();
I think once the class is renamed to Network, current variable name won't look 
odd.

--
To view, visit http://gerrit.ovirt.org/4960
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d545f039cf0a9687ed3818086a50cbc39f7d861
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to