Sharad Mishra has posted comments on this change. Change subject: core: Failed to create bond on 3.0 cluster (#827114) ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java Line 6: import org.ovirt.engine.core.common.businessentities.network; Why do we have a class not starting with uppercase letter? I know its not related to this patch. Just curious. Line 51: network network = getParameters().getNetwork(); "network network" hmmm, nothing wrong as far as the functionality goes. But not very pleasing to eyes. -- To view, visit http://gerrit.ovirt.org/4960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d545f039cf0a9687ed3818086a50cbc39f7d861 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches