Moti Asayag has posted comments on this change. Change subject: core: Failed to create bond on 3.0 cluster (#827114) ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java Line 6: import org.ovirt.engine.core.common.businessentities.network; The code was originally converted from C# to Java. Class naming remains as it was converted. There is an ongoing effort to change the code to Java style. Specifically, the business entities from the common project requires an extra effort since they span all over the product: GUI, backend, Rest. Usually those patches are quite big (over tens of files), and have a lower priority, thought patches are more than welcome. Line 51: network network = getParameters().getNetwork(); any suggestions ? net? paramNetwork ? I guess it wouldn't look strange if the class name would have started with a capital 'N' (e.g. Network network = ...). -- To view, visit http://gerrit.ovirt.org/4960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d545f039cf0a9687ed3818086a50cbc39f7d861 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
