Tomas Jelinek has uploaded a new change for review. Change subject: userportal,webadmin: validation error on create template ......................................................................
userportal,webadmin: validation error on create template It was not possible to create a new template. The problem was that: - UnitVmModel.validate() did not pass the CPU validation: new IntegerValidation(1, behavior.maxCpus) because the behavior.maxCpus was not inited. - the behavior.maxCpus was not inited because it is inited in the VmModelBehaviorBase.updateMaxNumOfVmCpus() which is called which is triggered by calling the VmModelBehaviorBase.updateNumOfSockets() which is supposed to be called from the specific behavior classes' postDataCenterWithClusterSelectedItemChanged. - The problem was that the NewTemplateVmModelBehavior.postDataCenterWithClusterSelectedItemChanged did not called the updateNumOfSockets() Change-Id: Ida04f94dcbe4d357f306eec60134661c43d9fcdf Bug-Url: https://bugzilla.redhat.com/1085754 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/26595/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java index a19fd7b..ed83de4 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java @@ -277,6 +277,7 @@ updateVirtioScsiAvailability(); updateOSValues(); updateTemplate(); + updateNumOfSockets(); } @Override -- To view, visit http://gerrit.ovirt.org/26595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida04f94dcbe4d357f306eec60134661c43d9fcdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches