Vojtech Szocs has posted comments on this change. Change subject: webadmin: RunMultipleAction - error handling added ......................................................................
Patch Set 3: Updated patch set with following changes: - consolidated both Frontend RunMultipleAction methods as described in my previous comment - improved ErrorMessageFormatter, BTW why do we use things like "<br/><br/>" there? (this should be handled by styling) - no need for initial check in FrontendEventsHandlerImpl since it's only called from Frontend RunMultipleAction where the condition is already checked - added runMultipleActionFailed no-op impl. to original UserPortal FrontendEventsHandlerImpl (to ensure that original UserPortal still compiles without errors) -- To view, visit http://gerrit.ovirt.org/4878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9ab1c30b7352af029cc283ca98b6370388bb0e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
