Vojtech Szocs has posted comments on this change. Change subject: webadmin: RunMultipleAction - error handling added ......................................................................
Patch Set 2: These changes look good (need to verify), but there is one problem: in original UserPortal, org.ovirt.engine.ui.userportal.client.uicommonext.FrontendEventsHandlerImpl has compilation error due to IFrontendEventsHandler interface change. I suggest to add no-op (empty) runMultipleActionFailed method implementation into org.ovirt.engine.ui.userportal.client.uicommonext.FrontendEventsHandlerImpl, to ensure that original UserPortal can still be compiled. On the other hand, with backend query permission checking enabled (QueriesCommandBase.validatePermissions method), and with original UserPortal not adapted to user queries, I guess the only way to make original UserPortal work is to disable backend query permission checking. Since original UserPortal is no longer part of the standard Maven build, we can make a patch to remove it. Gilad/Daniel - any thoughts/suggestions? -- To view, visit http://gerrit.ovirt.org/4878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9ab1c30b7352af029cc283ca98b6370388bb0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
