Vojtech Szocs has posted comments on this change. Change subject: webadmin: RunMultipleAction - error handling added ......................................................................
Patch Set 2: This patch changes method: RunMultipleAction(VdcActionType, ArrayList<VdcActionParametersBase>, IFrontendMultipleActionAsyncCallback, Object) But there is another method which does the same thing, except for callback handling: RunMultipleAction(VdcActionType, ArrayList<VdcActionParametersBase>) I suggest to update the first method -> allow null value for 'callback' and 'state' parameters, so that second method can just call first one with 'callback' and 'state' set to null. This way, both methods will have the same error handling. -- To view, visit http://gerrit.ovirt.org/4878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d9ab1c30b7352af029cc283ca98b6370388bb0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
