[Engine-patches] Change in ovirt-engine[master]: webadmin: Remove dynamic query from Configure Local Storage

[lzelkha]

Liran Zelkha has uploaded a new change for review.

Change subject: webadmin: Remove dynamic query from Configure Local Storage
......................................................................

webadmin: Remove dynamic query from Configure Local Storage

Since dynamic queries are problematic from a performance perspective
we replace them with regular query usage.
This patch removes it from the Configure Local Storage action.

Change-Id: I345d9df45dc743d6223897d839e7eb72996ad037
Signed-off-by: lzel...@redhat.com <lzel...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
2 files changed, 10 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/26545/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
index 25cc28a..4408530 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
@@ -25,6 +25,8 @@
      */
     private boolean isFiltered;
 
+    private boolean isSorted;
+
     public VdcQueryParametersBase() {
         refresh = true;
     }
diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
index 609ec00..279005b 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
@@ -560,15 +560,18 @@
             @Override
             public Object Convert(Object source, AsyncQuery _asyncQuery)
             {
-                if (source == null)
+                List<VDSGroup> result = new ArrayList<VDSGroup>();
+                if (source == null || !(source instanceof VDSGroup))
                 {
-                    return new ArrayList<VDSGroup>();
+                    return result;
                 }
-                return source;
+                result.add((VDSGroup) source);
+                return result;
             }
         };
-        Frontend.getInstance().runQuery(VdcQueryType.Search,
-                new SearchParameters("Cluster: name=" + name + " sortby name", 
SearchType.Cluster), //$NON-NLS-1$ //$NON-NLS-2$
+
+        Frontend.getInstance().runQuery(VdcQueryType.GetVdsGroupByName,
+                new NameQueryParameters(name),
                 aQuery);
     }
 


-- 
To view, visit http://gerrit.ovirt.org/26545
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I345d9df45dc743d6223897d839e7eb72996ad037
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches