Liran Zelkha has posted comments on this change. Change subject: webadmin: Remove dynamic query from Configure Local Storage ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/26545/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java: Line 24: * (e.g., according to user permissions as opposed to the default, which is running as admin) Line 25: */ Line 26: private boolean isFiltered; Line 27: Line 28: private boolean isSorted; > is it related to this patch? Done Line 29: Line 30: public VdcQueryParametersBase() { Line 31: refresh = true; Line 32: } http://gerrit.ovirt.org/#/c/26545/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 560: @Override Line 561: public Object Convert(Object source, AsyncQuery _asyncQuery) Line 562: { Line 563: List<VDSGroup> result = new ArrayList<VDSGroup>(); Line 564: if (source == null || !(source instanceof VDSGroup)) > when can the query return a non VDSGroup object? on failure? Done Line 565: { Line 566: return result; Line 567: } Line 568: result.add((VDSGroup) source); Line 570: } Line 571: }; Line 572: Line 573: Frontend.getInstance().runQuery(VdcQueryType.GetVdsGroupByName, Line 574: new NameQueryParameters(name), > iiuc, it should be sorted by default? This method is looking for a cluster by name - only one exists. No sorting needed ;-) Line 575: aQuery); Line 576: } Line 577: Line 578: public static void getPoolById(AsyncQuery aQuery, Guid poolId) { -- To view, visit http://gerrit.ovirt.org/26545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I345d9df45dc743d6223897d839e7eb72996ad037 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
