Maor Lipchuk has posted comments on this change. Change subject: core: added GetAllSnapshotImagesByStorageDomainIdQuery ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/26323/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSnapshotImagesByStorageDomainIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllSnapshotImagesByStorageDomainIdQuery.java: Line 38: return diskImage.getVmSnapshotId().equals(((Snapshot) snapshot).getId()); Line 39: } Line 40: }); Line 41: Line 42: if (snapshot != null) { When can we get a disk without snapshot? why should we return it in the list? Line 43: diskImage.setVmSnapshotDescription(snapshot.getDescription()); Line 44: } Line 45: } Line 46: -- To view, visit http://gerrit.ovirt.org/26323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I389579e4120cb33edca594caa762a8bad63362b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
