Yair Zaslavsky has posted comments on this change. Change subject: aaa: using the new extensions API in InternalDirectory ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/26477/4/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java: Line 73: output.mput( Line 74: Base.InvokeKeys.RESULT, Base.InvokeResult.FAILED Line 75: ).mput( Line 76: Base.InvokeKeys.MESSAGE, ex.getMessage() Line 77: ); > btw: don't you like to log these exceptions? Well, I wanted to discuss that. Log using TRACE_LOG that is put on context? I don't have the TRACE_LOG key as it is deined in ExtensionsManager. Log using the regular logger? Line 78: } Line 79: } Line 80: Line 81: Line 102: } Line 103: Line 104: Line 105: Line 106: private void doFetchPrincipalRecord(ExtMap input, ExtMap output) { > check that the admin is on input?!?! Done Line 107: output.put(Authz.InvokeKeys.PRINCIPAL_RECORD, adminUser); Line 108: fillSuccess(output); Line 109: } Line 110: -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
