Alon Bar-Lev has posted comments on this change. Change subject: aaa: using the new extensions API in InternalDirectory ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26477/5/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java: Line 29: Authz.InvokeCommands.QUERY_PRINCIPALS_BY_IDS_OPEN, Line 30: Authz.InvokeCommands.QUERY_GROUPS_BY_IDS_OPEN) Line 31: ); Line 32: Line 33: private static final Set<ExtUUID> OTHER_AUTHZ_COMMANDS = > there is a way :) and there is the conservative... static { set4 = new HashSet<String>(set1); set4.addAll(Array.asList("C", "D")); } so if you want to have two static sets, one with x commands and one with x+y commands it is possible in several different ways. Line 34: new HashSet<>(Arrays.asList(Authz.InvokeCommands.QUERY_CLOSE, Authz.InvokeCommands.FETCH_PRINCIPAL_RECORD)); Line 35: private ExtMap context; Line 36: Line 37: private ExtMap adminUser; -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches