Alon Bar-Lev has posted comments on this change. Change subject: aaa: using the new extensions API in InternalDirectory ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/26477/3/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/DirectoryProxy.java: Line 90: Base.InvokeKeys.COMMAND, Authz.InvokeCommands.QUERY_EXECUTE Line 91: ).mput(Authz.InvokeKeys.QUERY_OPAQUE, queryOpaque); Line 92: outputMap = extension.invoke(inputMap); Line 93: ExtMap result = outputMap.get(Authz.InvokeKeys.QUERY_RESULT); Line 94: queryOpaque = outputMap.get(Authz.InvokeKeys.QUERY_OPAQUE); > Don't I need to get it in each iteration? nope, just like file descriptor... you get it from open... and use. Line 95: if (result == null) { Line 96: break; Line 97: } Line 98: directoryUsers.add(mapPrincipalRecord(result)); http://gerrit.ovirt.org/#/c/26477/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalDirectory.java: Line 76: opaque.setSecond(false); Line 77: output.mput( Line 78: Authz.InvokeKeys.QUERY_RESULT, Arrays.asList(adminUser) Line 79: ).mput( Line 80: Authz.InvokeKeys.QUERY_OPAQUE, opaque > What do you mean? where do I reset it? re-set/re-put, only open should put this not execute. Line 81: ); Line 82: } else { Line 83: output.mput( Line 84: Authz.InvokeKeys.QUERY_RESULT, null -- To view, visit http://gerrit.ovirt.org/26477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I958443292da0455e0a12039fac98eebb9b17dee2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
