Alon Bar-Lev has posted comments on this change.

Change subject: core: Add executePipe
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.ovirt.org/#/c/26213/14/src/otopi/plugin.py
File src/otopi/plugin.py:

Line 665:             return ret
Line 666: 
Line 667:         res['stdout'] = _splitstream(res['stdout'])
Line 668:         for r in res['result']:
Line 669:             r['stderr'] = _splitstream(r['stderr'])
> how can it fail here... r['stderr'] = None, what do i miss?
ok, the problem is in debug print, will fix.
Line 670: 
Line 671:         if logStreams:
Line 672:             self.logger.debug(
Line 673:                 'executePipe-output: %s stdout:\n%s\n',


-- 
To view, visit http://gerrit.ovirt.org/26213
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912
Gerrit-PatchSet: 14
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to