Alon Bar-Lev has posted comments on this change. Change subject: core: Add executePipe ......................................................................
Patch Set 14: (2 comments) http://gerrit.ovirt.org/#/c/26213/14/src/otopi/plugin.py File src/otopi/plugin.py: Line 396: if ( Line 397: stdin is None or Line 398: isinstance(stdin, bytes) or Line 399: isinstance(stdin, str) or Line 400: isinstance(stdin, unicode) ok Line 401: ): Line 402: stdindata = stdin Line 403: stdin = None Line 404: Line 653: **kwargs Line 654: ) Line 655: Line 656: def _splitstream(s): Line 657: ret = [] why? if no stream it should be None Line 658: if s is not None: Line 659: if not isinstance(s, bytes) and not isinstance(s, str): Line 660: s = s.read() Line 661: if isinstance(s, bytes): -- To view, visit http://gerrit.ovirt.org/26213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Gerrit-PatchSet: 14 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
