Yedidyah Bar David has posted comments on this change. Change subject: core: Add executePipe ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/26213/13/src/otopi/plugin.py File src/otopi/plugin.py: Line 505: should_close = False Line 506: entry, events = fds[r[0]], r[1] Line 507: if (events & select.POLLOUT) != 0: Line 508: try: Line 509: count = os.write( > hmmm... write should perform size or less. but you are correct, we can expl Well, not sure why, but I did not manage to make it block, even if I set CHUNK_SIZE large (MBs) and stdin large (hundreds MBs). Basically it seems good, I have just two tiny fixes - I'll push and you'll comment... Line 510: entry['fd'], Line 511: entry['buffer'][ Line 512: entry['index']: Line 513: entry['index'] + CHUNK_SIZE -- To view, visit http://gerrit.ovirt.org/26213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a434fbe1308ac2f603b8ae09756354c11138912 Gerrit-PatchSet: 13 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
