Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Ask whether to backup the database ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/26082/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py: Line 190: ) Line 191: return int(result[0]['size']) Line 192: Line 193: def _HumanReadableSize(self, bytes): Line 194: size_in_mb = bytes / pow(2,20) > Isn't it simpler just having It's integer division. Line 195: return ( Line 196: _('{size} MB').format(size=size_in_mb) Line 197: if size_in_mb < 1024 Line 198: else _('{size} GB').format(size=float(size_in_mb/pow(2, 10))) Line 194: size_in_mb = bytes / pow(2,20) Line 195: return ( Line 196: _('{size} MB').format(size=size_in_mb) Line 197: if size_in_mb < 1024 Line 198: else _('{size} GB').format(size=float(size_in_mb/pow(2, 10))) Here there is actually a bug :-) (also copied from 3.3) Line 199: ) Line 200: Line 201: @plugin.event( Line 202: stage=plugin.Stages.STAGE_INIT, Line 255: _( Line 256: 'Are you sure you do not want to backup the DWH ' Line 257: 'database?' Line 258: ) Line 259: perform_backup = not dialog.queryBoolean( > Check indentation What specifically? Ahh, I know what - you do not see the '_' before the '('. Seems like some bug in gerrit or the browser or whatever, not sure. Usually when I click around and/or refresh it does show them eventually. Line 260: dialog=self.dialog, Line 261: name='OVESETUP_DWH_VERIFY_NO_BACKUP', Line 262: note=_( Line 263: 'A positive reply makes sense only if ' -- To view, visit http://gerrit.ovirt.org/26082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
