Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Ask whether to backup the database ......................................................................
Patch Set 7: (2 comments) > Looks good to me, but as we discussed, on rollback the engine is not > restarted automatically so after "'Rollback of DWH database postponed to > Stage "Clean up"' maybe better add something like: "You can start the engine > while the DWH database rollback is running" I already do that at that point - don't you think it's enough? I think it's more useful to output right before the long delay as that's probably where the user will look first. http://gerrit.ovirt.org/#/c/26082/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py: Line 54: Line 55: def abort(self): Line 56: if ( Line 57: self._parent.environment[ Line 58: odwhcons.DBEnv.RESTORE_BACKUP_LATE > oh... this is not being asked... so what you suggest is to default restore I don't mind asking, but it's against our convention to ask during such a late stage (during rollback) and we felt it's not very encouraging to ask during customization. When did you intend to ask? Line 59: ] and Line 60: self._parent._backup Line 61: ): Line 62: self._parent._needRollback = True Line 58: odwhcons.DBEnv.RESTORE_BACKUP_LATE Line 59: ] and Line 60: self._parent._backup Line 61: ): Line 62: self._parent._needRollback = True > why do you need this and not relay only on environment, moving the check of Because in principle we can have more logic at this point. An example I thought about (and might add): If the db is "small", or we have some other means to guess that restore will be fast, do it here and not postpone. Another example: Barak wanted a third option, to not restore at all and just print a command to run for manual restore. I do not like this idea, mainly because we need to help generate a temporary pgpass, but we'll probably add it anyway later. We also talked about adding logic to check if we are running under 'screen' or 'tmux' (as we do in hosted-engine) and behave accordingly, to help the user commence with a very-long-running-restore while e.g. shutting down the laptop from which they connected to the server running restore. Not very related but I simply do not know yet all the details. Line 63: self._parent.logger.warning( Line 64: _('Rollback of DWH database postponed to Stage "Clean up"') Line 65: ) Line 66: else: -- To view, visit http://gerrit.ovirt.org/26082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
