Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Ask whether to backup the database ......................................................................
Patch Set 7: (4 comments) http://gerrit.ovirt.org/#/c/26082/7/packaging/setup/ovirt_engine_setup/dwhconstants.py File packaging/setup/ovirt_engine_setup/dwhconstants.py: Line 214: ) Line 215: def PERFORM_BACKUP(self): Line 216: return 'OVESETUP_DWH_DB/performBackup' Line 217: Line 218: RESTORE_BACKUP_LATE = 'OVESETUP_DWH_DB/restoreBackupLate' I guess you need this in answer file as well? Line 219: Line 220: Line 221: @util.export Line 222: @util.codegen http://gerrit.ovirt.org/#/c/26082/7/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py: Line 54: Line 55: def abort(self): Line 56: if ( Line 57: self._parent.environment[ Line 58: odwhcons.DBEnv.RESTORE_BACKUP_LATE oh... this is not being asked... so what you suggest is to default restore not as part of transaction unless user looks into our environment to see that there is safe method? why not ask? Line 59: ] and Line 60: self._parent._backup Line 61: ): Line 62: self._parent._needRollback = True Line 58: odwhcons.DBEnv.RESTORE_BACKUP_LATE Line 59: ] and Line 60: self._parent._backup Line 61: ): Line 62: self._parent._needRollback = True why do you need this and not relay only on environment, moving the check of _backup to the rollback? Line 63: self._parent.logger.warning( Line 64: _('Rollback of DWH database postponed to Stage "Clean up"') Line 65: ) Line 66: else: Line 383: Line 384: @plugin.event( Line 385: stage=plugin.Stages.STAGE_CLEANUP, Line 386: priority=plugin.Stages.PRIORITY_LAST, Line 387: condition=lambda self: self._needRollback, should be based on environment Line 388: ) Line 389: def _rollback(self): Line 390: self.logger.warning( Line 391: _('Rollback of DWH database started') -- To view, visit http://gerrit.ovirt.org/26082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e113bddaeeb71b00f5a524db0be3a24fa6f9907 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
