Maor Lipchuk has posted comments on this change. Change subject: core: Remove a proxy use of ImagesHandler filter ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/26205/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 337: return db.getVmInitByIds(ids); Line 338: } Line 339: Line 340: /** Line 341: * Filters the vm image disks/disk devices note: luns will be filtered. > please move the "note" part to the line below this is java doc, it is without <BR> so you will eventually see it the same way when reading it in the code. I will change it just to get forward with it. Line 342: */ Line 343: public static void filterImageDisksForVM(VM vm) { Line 344: List<DiskImage> filteredDisks = ImagesHandler.filterImageDisks(vm.getDiskMap().values(), false, false, true); Line 345: Collection<? extends Disk> vmDisksToRemove = CollectionUtils.subtract(vm.getDiskMap().values(), filteredDisks); -- To view, visit http://gerrit.ovirt.org/26205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87f74d76771b3fe3fb31a4d9c731ec0139515694 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
