Liron Ar has posted comments on this change. Change subject: core: Remove a proxy use of ImagesHandler filter ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26205/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 337: return db.getVmInitByIds(ids); Line 338: } Line 339: Line 340: /** Line 341: * Filters the vm image disks/disk devices.<BR/> > no need to remove it I don't see any point in having it, but as we have it on other places..fine by me. please add to the javadoc what's being filtered as it's not being passed in the parameters anymore(I'm not sure why you removed it in this revision). just write - Filters the vm attached disk snapshots/luns and the corresponding vm devices. Line 342: * note: luns will be filtered. Line 343: */ Line 344: public static void filterImageDisksForVM(VM vm) { Line 345: List<DiskImage> filteredDisks = ImagesHandler.filterImageDisks(vm.getDiskMap().values(), false, false, true); -- To view, visit http://gerrit.ovirt.org/26205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87f74d76771b3fe3fb31a4d9c731ec0139515694 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
