Maor Lipchuk has posted comments on this change. Change subject: core: Remove a proxy use of ImagesHandler filter ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26205/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 336: VmInitDAO db = DbFacade.getInstance().getVmInitDao(); Line 337: return db.getVmInitByIds(ids); Line 338: } Line 339: Line 340: public static void filterImageDisksForVM(VM vm) { > I'd add a comment/Java doc about why a filter of images disk is done like t done Line 341: List<DiskImage> filteredDisks = ImagesHandler.filterImageDisks(vm.getDiskMap().values(), false, false, true); Line 342: Collection<? extends Disk> vmDisksToRemove = CollectionUtils.subtract(vm.getDiskMap().values(), filteredDisks); Line 343: vm.clearDisks(); Line 344: updateDisksForVm(vm, filteredDisks); -- To view, visit http://gerrit.ovirt.org/26205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87f74d76771b3fe3fb31a4d9c731ec0139515694 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
