Oved Ourfali has posted comments on this change. Change subject: backend: bugfix in VdsManager on failedToRunVm ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26139/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 480: Line 481: /** Line 482: * Move vds to Up status from error Line 483: */ Line 484: if ( vds.getStatus() == VDSStatus.Error) { > I guess it would be null in that case. I think Omer meant to check if ( vds != null && vds.getStatus() == VDSStatus.Error) Line 485: mFailedToRunVmAttempts.set(0); Line 486: setStatus(VDSStatus.Up, vds); Line 487: DbFacade.getInstance().getVdsDynamicDao().updateStatus(getVdsId(), VDSStatus.Up); Line 488: log.infoFormat("onVdsDuringFailureTimer of Host {0} entered after {1} attempts to run a VM", -- To view, visit http://gerrit.ovirt.org/26139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
