Oved Ourfali has posted comments on this change. Change subject: backend: bugfix in VdsManager on failedToRunVm ......................................................................
Patch Set 1: Code-Review+1 (3 comments) minor commit message comments. http://gerrit.ovirt.org/#/c/26139/1//COMMIT_MSG Commit Message: Line 6: Line 7: backend: bugfix in VdsManager on failedToRunVm Line 8: Line 9: Bug description: onVdsDuringFailureTimer assumes that number Line 10: of attempts is always >= 0 but this assumption breaks. the but this assumption is not always true. Line 11: reason for this is that pausing a quartz job does not insure Line 12: it will not run anymore but simply pauses the trigger, so Line 13: previously scheduled jobs might still run. this is resolved Line 14: by using simpler one time scheduling. Line 9: Bug description: onVdsDuringFailureTimer assumes that number Line 10: of attempts is always >= 0 but this assumption breaks. the Line 11: reason for this is that pausing a quartz job does not insure Line 12: it will not run anymore but simply pauses the trigger, so Line 13: previously scheduled jobs might still run. this is resolved Put capital letter after "." Line 14: by using simpler one time scheduling. Line 15: Line 16: This patch introduces a behavioral change: Line 17: previously onVdsDuringFailureTimer would reduce failed attempt Line 17: previously onVdsDuringFailureTimer would reduce failed attempt Line 18: by 1 (which is problamatic since it no longer represents failed Line 19: attempts when it is decremented by 1 every x time). previously Line 20: there would be a competition between onVdsDuringFailureTimer calls Line 21: to failedToRunVm calls. Now when ever attempt limit is reached whenever Line 22: number of attempts is set to 0. The effect of this is if we have Line 23: a host failing to run vms and those vms were able to run on other hosts Line 24: and we detect no oter problem on in (its status is up) Line 25: it will keep trying to recover every 30 min (default) regardless. -- To view, visit http://gerrit.ovirt.org/26139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
