mooli tayer has posted comments on this change.

Change subject: backend: bugfix in VdsManager on failedToRunVm
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/26139/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java:

Line 474:      * Error status.
Line 475:      */
Line 476:     @OnTimerMethodAnnotation("onVdsDuringFailureTimer")
Line 477:     public void onVdsDuringFailureTimer() {
Line 478:         synchronized (getLockObj()) {
I will remove the synchronized since it is no longer needed.
Line 479:             VDS vds = 
DbFacade.getInstance().getVdsDao().get(getVdsId());
Line 480: 
Line 481:             /**
Line 482:              * Move vds to Up status from error


-- 
To view, visit http://gerrit.ovirt.org/26139
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd140ceecf4954e65ea3f6174a41acea82f6a6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to