Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Introducing format to id of User and Group API entities
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/26191/4//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: The following format will be used to represent the value of id
Line 10: in User and Group API entities:
Line 11: 
Line 12: id = url_encode (id=<internal_id>:provider_id=<provider_id>)
why do we still have both?

again... should be or:

 urlencode(id=<string>)

or:

 urlencode(providerid=<directory>:<string>)
Line 13: 
Line 14: internal_id= the primary key of the user or group as stored in db
Line 15: provider_id = <directory_name>:<id_of_entity_in_directory>
Line 16: 


-- 
To view, visit http://gerrit.ovirt.org/26191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to