Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing format to id of User and Group API entities ......................................................................
Patch Set 4: Alon, in your comment - " we can access the same user as (removing the urlencode): /users/id=4d42ec8d-7eca-47da-9a54-9f48fc896072 /users/provider_id=example.com:4d42ec8d-7eca-47da-9a54-9f48fc896072 " What is the point in accessing a user using provider id, if already added in the db? I think we should not not do that. A user of the API should be able to query /users and get a list of users and the "id" for each one it can use to further query a single user. Since in the format you would like to present either intenral id or provider id, then the use case i suggested will break for one of the ways you suggested to query /api/users Regarding the other comments - something is still bothering me with the requirement to support both IDs for /domains/xxx/users - a. once again - if we don't want to show BOTH internal id AND provider id for the same user - it means that for some users you will show the provider id, and for some (those that are already in db) the user id? Not sure how much this is consistent when it comes to the way users are present in this collection. b. when you mention clients of < 3.5 - when the fix that reverts the api will be merged you will get back the internal_id is ALWAYS EQUAL to provider id. You can access the same ID . After you add a user to db, you will be able to take its id (let's say zzz) and query again /domains/xxxx/users/zzz and get the same result. How do you intend to handle this use case? -- To view, visit http://gerrit.ovirt.org/26191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaecb5d43945769db82475edde1c7075c1a343c07 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
