Kobi Ianko has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java: Line 83: if (!entityChangedEvent.getListeners().contains(getView().getDiskTypeChangedEventListener())) { Line 84: entityChangedEvent.addListener(getView().getDiskTypeChangedEventListener()); Line 85: } Line 86: Line 87: Event systemTreeSelectedItemChangedEvent = > if it works, it might simplify the code by using a less complex flow while it is agreed to test this option on a later patch Line 88: CommonModel.getInstance().getSystemTree().getSelectedItemChangedEvent(); Line 89: systemTreeSelectedItemChangedEvent.addListener(systemTreeListener); Line 90: Line 91: super.onReveal(); -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
