Gilad Chaplik has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 10: (5 comments) @Daniel, this is in your domain as well, please take a look. thanks. http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java: Line 436: Line 437: SystemTreeItemModel dataCenterItem = new SystemTreeItemModel(); Line 438: dataCenterItem.setType(SystemTreeItemType.DataCenter); Line 439: dataCenterItem.setApplicationMode(ApplicationMode.VirtOnly); Line 440: StoragePool storagePool = getDataCenters().get(count); 1) I prefer calling it dataCenter in the UI 2) iiuc, this change in irrelevant for this patch. no need to change it, now just bare in mind in future changes. Line 441: dataCenterItem.setTitle(storagePool.getName()); Line 442: dataCenterItem.setEntity(storagePool); Line 443: dataCentersItem.addChild(dataCenterItem); Line 444: treeItemById.put(storagePool.getId(), dataCenterItem); http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java: Line 772: } else { Line 773: // Update the Quota at the corresponding DC object at the system tree. Line 774: // The DC Quota value from the tree is used at MainTabDiskView. Line 775: SystemTreeItemModel itemModel = CommonModel.getInstance().getSystemTree().getItemById(dataCenter.getId()); Line 776: itemModel.setEntity(dataCenter); please verify the scenario where dc is remove but still exists in the tree. Line 777: Line 778: // Otherwise use async action in order to close dialog immediately. Line 779: Frontend.getInstance().runMultipleAction(VdcActionType.UpdateStoragePool, Line 780: new ArrayList<VdcActionParametersBase>(Arrays.asList( http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabDiskPresenter.java: Line 47: void handleQuotaColumnVisibility(); Line 48: Line 49: } Line 50: Line 51: final IEventListener systemTreeListener = new IEventListener() { private? Line 52: @Override Line 53: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 54: getView().handleQuotaColumnVisibility(); Line 55: } Line 97: super.onHide(); Line 98: Event systemTreeSelectedItemChangedEvent = Line 99: CommonModel.getInstance().getSystemTree().getSelectedItemChangedEvent(); Line 100: systemTreeSelectedItemChangedEvent.removeListener(systemTreeListener); Line 101: } this code looks suspicious... http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java: Line 92: if (QuotaEnforcementTypeEnum.DISABLED != storagePool.getQuotaEnforcementType()) { Line 93: isQuotaVisible = true; Line 94: } Line 95: } Line 96: onDiskViewTypeChanged(); also this one. not sure it's the right place for it. Line 97: } Line 98: Line 99: void onDiskViewTypeChanged() { Line 100: boolean all = disksViewRadioGroup.getAllButton().getValue(); -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
