Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Adding Quota column to the Disk tab
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/25068/10/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java:

Line 436: 
Line 437:             SystemTreeItemModel dataCenterItem = new 
SystemTreeItemModel();
Line 438:             dataCenterItem.setType(SystemTreeItemType.DataCenter);
Line 439:             
dataCenterItem.setApplicationMode(ApplicationMode.VirtOnly);
Line 440:             StoragePool storagePool = getDataCenters().get(count);
> 1) I prefer calling it dataCenter in the UI
ignore 2. meant to remove it, after I saw the rest of the patch.
Line 441:             dataCenterItem.setTitle(storagePool.getName());
Line 442:             dataCenterItem.setEntity(storagePool);
Line 443:             dataCentersItem.addChild(dataCenterItem);
Line 444:             treeItemById.put(storagePool.getId(), dataCenterItem);


-- 
To view, visit http://gerrit.ovirt.org/25068
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to