Martin Peřina has posted comments on this change. Change subject: aaa: Findbugs fixes ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/25781/4/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 234: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LdapServers); Line 235: String ldapProviderTypes = Line 236: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPProviderTypes); Line 237: String ldapPort = Line 238: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPServerPort); Checking ldapPort to null is not needed anymore? Line 239: String changePasswordUrl = Line 240: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.ChangePasswordMsg); Line 241: Line 242: configurationProvider = Line 236: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPProviderTypes); Line 237: String ldapPort = Line 238: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPServerPort); Line 239: String changePasswordUrl = Line 240: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.ChangePasswordMsg); Checking changePasswordUrl to null is not needed anymore? Line 241: Line 242: configurationProvider = Line 243: new ConfigurationProvider(adUserName, Line 244: adUserPassword, http://gerrit.ovirt.org/#/c/25781/4/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsConfiguration.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsConfiguration.java: Line 14: private static String DOMAIN_REALM_MAPPING_FILE = "domainRealmMappingFile"; Line 15: Line 16: ManageDomainsConfiguration(String confFilePath) throws Exception { Line 17: manageDomainsConf = new Properties(); Line 18: try (FileInputStream inputStream = new FileInputStream(confFilePath)) { FileReader not needed here? Line 19: manageDomainsConf.load(inputStream); Line 20: } Line 21: } Line 22: -- To view, visit http://gerrit.ovirt.org/25781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34674920d96ae447e15b96ccc26009f075e85ca3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
