Martin Peřina has posted comments on this change. Change subject: aaa: Findbugs fixes ......................................................................
Patch Set 3: (5 comments) http://gerrit.ovirt.org/#/c/25781/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerBase.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapBrokerBase.java: Line 28: Constructor info = ReflectionUtils.findConstructor(type, parameters.getClass()); Line 29: Object tempVar = info.newInstance(parameters); Line 30: return (BrokerCommandBase) ((tempVar instanceof BrokerCommandBase) ? tempVar : null); Line 31: } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | IllegalArgumentException Line 32: | InvocationTargetException e) { Why not simply catch Exception, since you don't do special handling for each exception class? Line 33: log.errorFormat("LdapBrokerCommandBase: Failed to get type information using reflection for Action: {0}", Line 34: action); Line 35: return null; Line 36: } http://gerrit.ovirt.org/#/c/25781/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 238: String ldapProviderTypes = Line 239: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPProviderTypes); Line 240: String ldapPort = Line 241: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPServerPort); Line 242: if (ldapPort.equals("")) { > findbugs claimed that ldapPort cannot be null. Please use StringUtils.isBlank() Line 243: ldapPort = DEFAULT_LDAP_SERVER_PORT; Line 244: } Line 245: String changePasswordUrl = Line 246: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.ChangePasswordMsg); Line 363: return value; Line 364: } Line 365: Line 366: private String readPasswordFile(String passwordFile) throws FileNotFoundException, IOException { Line 367: try (BufferedReader reader = new BufferedReader(new InputStreamReader(new FileInputStream(passwordFile), Charset.defaultCharset().displayName()))) { I would use new BufferedReader(new FileReader(propFile)) FileReader does conversion from Unicode to platform default encoding. Line 368: String readLine = reader.readLine(); Line 369: return readLine; Line 370: } Line 371: } Line 1126: throw new ManageDomainsResult(ManageDomainsResultEnum.ERROR_CREATING_PROPERTIES_FILE, Line 1127: ex.getMessage()); Line 1128: } Line 1129: Line 1130: try (BufferedWriter fw = new BufferedWriter(new OutputStreamWriter(new FileOutputStream(propFile), Charset.defaultCharset().displayName()))) { I would use new BufferedWriter(new FileWriter(propFile)) FileWriter does conversion from Unicode to platform default encoding. Line 1131: fw.write(new StringBuilder() Line 1132: .append(ConfigValues.AdUserName.name()) Line 1133: .append("=\n") Line 1134: .append(ConfigValues.AdUserPassword.name()) http://gerrit.ovirt.org/#/c/25781/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsConfiguration.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsConfiguration.java: Line 14: private static String DOMAIN_REALM_MAPPING_FILE = "domainRealmMappingFile"; Line 15: Line 16: ManageDomainsConfiguration(String confFilePath) throws Exception { Line 17: manageDomainsConf = new Properties(); Line 18: try (FileInputStream inputStream = new FileInputStream(confFilePath)) { Also here I would use FileReader Line 19: manageDomainsConf.load(inputStream); Line 20: } Line 21: } Line 22: -- To view, visit http://gerrit.ovirt.org/25781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34674920d96ae447e15b96ccc26009f075e85ca3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
