Yair Zaslavsky has posted comments on this change. Change subject: aaa: Findbugs fixes ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/25781/3/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 241 Line 242 Line 243 Line 244 Line 245 findbug claimed the changepasswordUrl cannot be null. Line 238: String ldapProviderTypes = Line 239: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPProviderTypes); Line 240: String ldapPort = Line 241: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.LDAPServerPort); Line 242: if (ldapPort.equals("")) { findbugs claimed that ldapPort cannot be null. Line 243: ldapPort = DEFAULT_LDAP_SERVER_PORT; Line 244: } Line 245: String changePasswordUrl = Line 246: getConfigValue(engineConfigExecutable, engineConfigProperties, ConfigValues.ChangePasswordMsg); -- To view, visit http://gerrit.ovirt.org/25781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34674920d96ae447e15b96ccc26009f075e85ca3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
